Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: env to use path params in download url #19525

Closed
wants to merge 1 commit into from
Closed

feat: env to use path params in download url #19525

wants to merge 1 commit into from

Conversation

HarlesPilter
Copy link
Contributor

User facing changelog

Add CYPRESS_DOWNLOAD_PATH_PARAMS env variable to use path based params instead of query based params in download url.

Additional details

  • Why was this change necessary? - After Add Paths and .zip to Download URLs #17291 was merged there was no way to switch the download url form query based parameters to path parameters.
  • What is affected by this change? -> Cypress CLI. Support for new env variable

How has the user experience changed?

If the CYPRESS_DOWNLOAD_PATH_PARAMS is set to true then cypress is downloaded using path based params(https://download.cypress.io/desktop/0.20.2/OS-ARCH/cypress.zip)
If the new env variable is not used then download url doesn't change (uses query based params https://download.cypress.io/desktop/0.20.2?platform=OS&arch=ARCH)

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@HarlesPilter HarlesPilter requested a review from a team as a code owner January 3, 2022 18:17
@HarlesPilter HarlesPilter requested review from jennifer-shehane and removed request for a team January 3, 2022 18:17
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 3, 2022

Thanks for taking the time to open a PR!

@HarlesPilter HarlesPilter deleted the issue-15697-path-download-env branch January 3, 2022 18:30
@HarlesPilter HarlesPilter restored the issue-15697-path-download-env branch January 3, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing Cypress with CYPRESS_DOWNLOAD_MIRROR and Artifactory
1 participant