Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: should/and chainer autocomplete #1132

Merged
merged 4 commits into from
Jan 9, 2018

Conversation

NicholasBoll
Copy link
Contributor

@NicholasBoll NicholasBoll commented Dec 27, 2017

Added a lot of documentation to chainer autocomplete interface. Below is a video of the experience:

cypress-chainer-updated

Related to #1040
Addresses chainer documentation concern of #1117

Also fixed an issue with .within types when using options.

@bahmutov
Copy link
Contributor

great work! 👍

Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@NicholasBoll NicholasBoll mentioned this pull request Dec 28, 2017
5 tasks
@NicholasBoll
Copy link
Contributor Author

Is there any additional work that needs to be done for this PR?

@brian-mann brian-mann merged commit a51ea1f into cypress-io:develop Jan 9, 2018
@brian-mann brian-mann added this to the 1.4.2 milestone Feb 4, 2018
@brian-mann
Copy link
Member

brian-mann commented Feb 5, 2018

Released in 1.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants