Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse domains/subdomains/tld using public suffix #802

Closed
brian-mann opened this issue Oct 24, 2017 · 3 comments
Closed

Parse domains/subdomains/tld using public suffix #802

brian-mann opened this issue Oct 24, 2017 · 3 comments
Assignees
@brian-mann
Labels
type: bug
Milestone
1.4.2

Comments

@brian-mann
Copy link
Member

Currently Cypress does a naive attempt at determining the domain, subdomain, and TLD of the current application under test.

It does not consider the public suffix, which results in it setting incorrect document.domain as well as yelling about changing domains when it's really not.

We should package in this npm module and then either make calls for parsing async (and do it in node) or transfer the data to Cypress during its bootstrap phase so it can parse it in the driver correctly.

Related to #380 and #600
@brian-mann brian-mann self-assigned this Oct 24, 2017
@jennifer-shehane jennifer-shehane added the stage: ready for work The issue is reproducible and in scope label Nov 1, 2017
@TomPridham
Copy link

do you guys have an ETA on this or a suggestion of where to start with this?

This was referenced Jan 8, 2018
Closed
Closed
@ghost
Copy link

ghost commented Jan 9, 2018

Same here. I can't get it running locally because my test domain contains "local" (and sorry, no, that's not easy to be changed in our setup).

@brian-mann brian-mann mentioned this issue Jan 9, 2018
Closed
@brian-mann brian-mann added this to the 1.4.2 milestone Feb 4, 2018
brian-mann added a commit that referenced this issue Feb 4, 2018
@brian-mann
server: fixes #802 and fixes #380 and fixes #402 and fixes #493 and f…
2b836a1 
…ixes #1161

- use the public suffix when parsing tld’s so that document.domain is
set correctly
brian-mann added a commit that referenced this issue Feb 4, 2018
@brian-mann
Issue 1175 (#1257)
e08778d 
* server: fixes #802 and fixes #380 and fixes #402 and fixes #493 and fixes #1161

- use the public suffix when parsing tld’s so that document.domain is
set correctly

* driver: move location spec back into cypress tests

* server, driver: fixes: #600 and fixes #1175 use public suffix for parsing tld, handle multiple different subdomains on cy.visit
@brian-mann
Copy link
Member Author

brian-mann commented Feb 5, 2018 •
edited
Loading

Released in 1.4.2.

@jennifer-shehane jennifer-shehane removed stage: ready for work The issue is reproducible and in scope labels Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
type: bug
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
3 participants
@brian-mann @jennifer-shehane @TomPridham