Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move binary_state.json file #6089

Closed
bahmutov opened this issue Jan 3, 2020 · 2 comments · Fixed by #6090
Closed

move binary_state.json file #6089

bahmutov opened this issue Jan 3, 2020 · 2 comments · Fixed by #6090
Labels
type: chore Work is required w/ no deliverable to end user

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Jan 3, 2020

Cypress v3.8.1

When Cypress starts for the very first time after installation, it checks that it can run using a smoke test and then saves its status in JSON file. Usually this file is inside ~/.cache/Cypress/<version>/<Cypress app>/binary_state.json. Unfortunately, this breaks the new Mac code notarization, see #6013 (comment) - no new files can be saved into the <Cypress app> folder.

I propose we move the binary_state.json file into ``~/.cache/Cypress//` folder instead.
This was referenced Jan 3, 2020
Merged
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jan 3, 2020
@jennifer-shehane jennifer-shehane added the type: chore Work is required w/ no deliverable to end user label Jan 6, 2020
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Jan 6, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 6, 2020

The code for this is done in cypress-io/cypress#6090, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane
Copy link
Member

Released in 3.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move binary state file to be in the version folder of the cache cypress-io/cypress
2 participants
@jennifer-shehane @bahmutov