Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should fail when something went wrong. #5771

Closed
sainthkh opened this issue Nov 22, 2019 · 3 comments · Fixed by #5779
Closed

CI should fail when something went wrong. #5771

sainthkh opened this issue Nov 22, 2019 · 3 comments · Fixed by #5779

Comments

@sainthkh
Copy link
Contributor

Current behavior:

Like #5734 and #5770, CI sometimes don't fail even when something went wrong.

Desired behavior:

CI should fail when something fails.

Steps to reproduce: (app code and test code)

Check issues above.

Versions

develop branch.

@sainthkh
Copy link
Contributor Author

sainthkh commented Nov 22, 2019

Left a message to mochajs/mocha#3893 for mocha problem. -> Meanwhile, we need to wrap the command with js script.

Currently investigating coffeelint problem. -> Fixed it by removing bin-up. coffeelint is used only in server. So, it's not a big deal.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 27, 2019

The code for this is done in cypress-io/cypress#5779, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 27, 2019

Released in 3.7.0.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant