Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped test icon looks too much like a stuck spinner #5366

Closed
krokofant opened this issue Oct 14, 2019 · 3 comments
Closed

Skipped test icon looks too much like a stuck spinner #5366

krokofant opened this issue Oct 14, 2019 · 3 comments

Comments

@krokofant
Copy link

Current behavior:

image

Desired behavior:

A better icon - I've looked through Font Awesome and didn't find anything especially good.

Steps to reproduce: (app code and test code)

/// <reference types="Cypress" />
describe('Login page integration', function() {
	it.skip('foo', () => {

	});
});

Versions

Cypress 3.4.1

@blumk
Copy link

blumk commented Oct 16, 2019

Proposal:
image

image

https://fontawesome.com/icons/ban?style=solid

@krokofant
Copy link
Author

@blumk Looks great to me!

@krokofant
Copy link
Author

Related issue #3092

Seems skipped and pending is not what you'd expect it to mean because cypress mimics the mocha design. The image seen in this issue is for a test with pending status. So not only is the terminology weird the ui is weird because of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants