Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot type negative number into number input with text selection #4767

Closed
kuceb opened this issue Jul 19, 2019 · 5 comments · Fixed by #4870
Closed

cannot type negative number into number input with text selection #4767

kuceb opened this issue Jul 19, 2019 · 5 comments · Fixed by #4870
Labels
stage: ready for work The issue is reproducible and in scope topic: cy.type ⌨️ type: bug

Comments

@kuceb
Copy link
Contributor

kuceb commented Jul 19, 2019 •
edited by jennifer-shehane
Loading

Cannot type negative number into number input with text selection

Relevant issue description: #2173 (comment)
This was referenced Jul 19, 2019
Closed
Closed
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Jul 22, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: ready for work The issue is reproducible and in scope and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Jul 23, 2019
@kuceb kuceb mentioned this issue Jul 24, 2019
Closed
5 tasks
@fr0
Copy link

fr0 commented Aug 2, 2019

I am also having this problem, but clear() doesn't work either (the text remains in the input box) so I'm somewhat stuck. Is there an ETA for a fix?

@kuceb
Copy link
Contributor Author

kuceb commented Aug 2, 2019

@fr0 if clear() isn't working for you it may be another issue. Could you post a reproducible or show a video?

@fr0
Copy link

fr0 commented Aug 2, 2019

@fr0 if clear() isn't working for you it may be another issue. Could you post a reproducible or show a video?

I discovered that my app had preventDefault() and stopPropagation() calls on the delete keydown handler that cypress was injecting. When I removed those the clear() worked.

@kuceb kuceb mentioned this issue Oct 18, 2019
Merged
17 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: ready for work The issue is reproducible and in scope stage: needs review The PR code is done & tested, needs review labels Oct 21, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

The code for this is done in cypress-io/cypress#4870, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 3, 2020
@cypress-io cypress-io unlocked this conversation Jan 3, 2020
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 3, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stage: ready for work The issue is reproducible and in scope topic: cy.type ⌨️ type: bug
Projects
None yet
Milestone
No milestone
2 participants
@fr0 @kuceb