Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle lowercase environment variables as well as uppercase ones #3865

Closed
flotwig opened this issue Apr 2, 2019 · 2 comments
Closed

Handle lowercase environment variables as well as uppercase ones #3865

flotwig opened this issue Apr 2, 2019 · 2 comments
Assignees
@flotwig

Comments

@flotwig
Copy link
Contributor

flotwig commented Apr 2, 2019

#3531 added support for the HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment variables. However, their lowercase counterparts http_proxy, https_proxy, and no_proxy are not considered, even though users are likely to use them. request library also supports these lowercase variable names out of the box.
@flotwig flotwig self-assigned this Apr 2, 2019
This was referenced Apr 2, 2019
Closed
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Apr 2, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Apr 3, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 3, 2019

The code for this is done in cypress-io/cypress#3866, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flotwig flotwig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flotwig