Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot recognize superdomain with multiple levels subdomain #380

Closed
yangliurea opened this issue Jan 18, 2017 · 2 comments
Closed

Cannot recognize superdomain with multiple levels subdomain #380

yangliurea opened this issue Jan 18, 2017 · 2 comments
Assignees
@brian-mann
Labels
type: bug type: enhancement Requested enhancement of existing feature
Milestone
1.4.2

Comments

@yangliurea
Copy link

Our url is xxx.xxx.xxx.com.au, before each test case, all the cookies under xxx.com.au should be clean, but they are always there, I tried using cy.clearCookies, but didn't work.
@jennifer-shehane jennifer-shehane added the stage: needs information Not enough info to reproduce the issue label Jan 20, 2017
@brian-mann
Copy link
Member

I've investigated this, and the problem is fairly simple but the solution will take a bit of work.

Basically we need to be as intelligent as the browser itself when parsing apart the domain into tld. The problem is that tld list is always changing, and browsers are constantly having to keep in sync with the latest lists, which we will also have to replicate.

So to do this "right" we're going to have to move logic out of the driver and make async calls to the backend to parse it correctly.

This will require some internal API changes since we synchronously parse URL's all over the place in the driver.

@brian-mann brian-mann added type: bug type: enhancement Requested enhancement of existing feature and removed stage: needs information Not enough info to reproduce the issue labels Jan 27, 2017
@brian-mann brian-mann mentioned this issue Jan 30, 2017
Closed
@brian-mann brian-mann mentioned this issue May 8, 2017
Closed
@brian-mann brian-mann mentioned this issue Aug 28, 2017
Closed
@brian-mann brian-mann mentioned this issue Oct 24, 2017
Closed
@brian-mann brian-mann added this to the 1.4.2 milestone Feb 4, 2018
brian-mann added a commit that referenced this issue Feb 4, 2018
@brian-mann
server: fixes #802 and fixes #380 and fixes #402 and fixes #493 and f…
2b836a1 
…ixes #1161

- use the public suffix when parsing tld’s so that document.domain is
set correctly
brian-mann added a commit that referenced this issue Feb 4, 2018
@brian-mann
Issue 1175 (#1257)
e08778d 
* server: fixes #802 and fixes #380 and fixes #402 and fixes #493 and fixes #1161

- use the public suffix when parsing tld’s so that document.domain is
set correctly

* driver: move location spec back into cypress tests

* server, driver: fixes: #600 and fixes #1175 use public suffix for parsing tld, handle multiple different subdomains on cy.visit
@brian-mann
Copy link
Member

brian-mann commented Feb 5, 2018 •
edited
Loading

Released in 1.4.2.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brian-mann brian-mann

Labels
type: bug type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
3 participants
@brian-mann @jennifer-shehane @yangliurea