app code that programmatically calls focus() doesn't work if the browser isn't the active window

[fr0]

Current behavior:

Try the following test:

      cy.visit('https://typescript-625eku.stackblitz.io');
      cy.get('#box').click();
      cy.wait(3000);
      cy.get('#box').trigger('keydown', {key: 'ArrowDown'});
      cy.get('#myInput').should('have.class', 'bright');

During the cy.wait, try either giving the browser focus, or giving another application focus. The test will pass/fail depending on this.

Desired behavior:

I think that focus behavior should not be this flaky. I frequently use cypress open and am typing in my editor while tests are running.

Steps to reproduce: (app code and test code)

https://stackblitz.com/edit/typescript-625eku?file=index.ts

Versions

3.1.5

[fr0]

Oddly enough, if you activate the browser window after the focus() method has been called, but before the test timeout occurs, it will pass. Looks like something's being queued up for when the browser is activated in that case.

[jennifer-shehane]

cc @bkucera - We've worked a lot on this focus behavior already and agree it should not be flaky.

[kuceb]

this is a duplicate of #1176 and is fixed in #2982

However I do think this issue title is more helpful in describing the bug, so thank you @fr0

[fr0]

Glad to know it's going to be fixed. Can I ask the obligatory "when can I have the fix?" :D

[kuceb]

@fr0 pending code review, most likely 3.2.