Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Quotes missing from error message. #2684

Closed
calvinballing opened this issue Oct 31, 2018 · 2 comments
Closed

Single Quotes missing from error message. #2684

calvinballing opened this issue Oct 31, 2018 · 2 comments
Labels
pkg/driver This is due to an issue in the packages/driver directory type: unexpected behavior User expected result, but got another
Milestone
Sprint 9

Comments

@calvinballing
Copy link
Contributor

Current behavior:

This error message does not display the single quotes that should be surrounding ":nth-child(2) > a". The single quotes are present in the code.
image

Desired behavior:

This error message (and any like it) correctly display the code as it is written in the file. In this case, it should include single quotes at the beginning and end.

Steps to reproduce:

Make a call like "cy.click(':nth-child(2) > a')"
This error message does not display the single quotes that should be surrounding ":nth-child(2) > a".

Versions

Cypress 3.1.0
Chrome
Windows 10
@jennifer-shehane jennifer-shehane added type: unexpected behavior User expected result, but got another pkg/driver This is due to an issue in the packages/driver directory stage: ready for work The issue is reproducible and in scope labels Nov 1, 2018
@jennifer-shehane
Copy link
Member

Somewhat related: #1360

@lilaconlee lilaconlee self-assigned this Nov 2, 2018
@lilaconlee lilaconlee mentioned this issue Nov 2, 2018
Merged
@lilaconlee lilaconlee added this to the Sprint 9 milestone Nov 2, 2018
chrisbreiding pushed a commit that referenced this issue Nov 20, 2018
@lilaconlee @chrisbreiding
Add quotes around strings in invoking child without parent error (#2713)
599785f 
- Fixes #2684
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: ready for work The issue is reproducible and in scope labels Dec 3, 2018
@jennifer-shehane
Copy link
Member

This was released in 3.1.5

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pkg/driver This is due to an issue in the packages/driver directory type: unexpected behavior User expected result, but got another
Projects
None yet
Milestone
Sprint 9
Development

No branches or pull requests
3 participants
@jennifer-shehane @calvinballing @lilaconlee