Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert.deepInclude() is not a function - update Chai to >=4.1.2 #1941

Closed
cuteporing opened this issue Jun 14, 2018 · 3 comments
Closed

assert.deepInclude() is not a function - update Chai to >=4.1.2 #1941

cuteporing opened this issue Jun 14, 2018 · 3 comments

Comments

@cuteporing
Copy link

cuteporing commented Jun 14, 2018

Current behavior:

Chai Assertion Library (http://www.chaijs.com/api/assert/) was referenced from Cypress.io Assertion docs (https://docs.cypress.io/guides/references/assertions.html#BDD-Assertions)

so I was under the impression that these API's actually works on Cypress.io. Some does like

assert.include()
assert.notIinclude()
assert.deepEqual()
assert.notDeepEqual()

but others don't like assert.deepInclude()

as shown on the screenshot below:

deepinclude

Desired behavior:

It would've been nice if this also works on Cypress. Otherwise the Chai Assertion Library link should not be part of the document for Cypress since it's going to be confusing.

Versions

Cypress: 2.1.0

@cuteporing cuteporing changed the title assert.deepInclude assert.deepInclude() is not a function on Cypress 2.1.0 Jun 14, 2018
@jennifer-shehane
Copy link
Member

I believe deepInclude was adding to Chai in version 4.1.2: chaijs/chai@7d1dd30

Cypress is using an older version of Chai and would need to update it for this to work.

@jennifer-shehane
Copy link
Member

This will work after updating Chai, which has a PR open for our 4.0 release.

@jennifer-shehane jennifer-shehane changed the title assert.deepInclude() is not a function on Cypress 2.1.0 assert.deepInclude() is not a function - update Chai to >=4.1.2 Jan 25, 2019
@jennifer-shehane
Copy link
Member

Released in 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants