Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the available plugin events in the scaffold file #1861

Closed
brian-mann opened this issue Jun 3, 2018 · 4 comments
Closed

Document the available plugin events in the scaffold file #1861

brian-mann opened this issue Jun 3, 2018 · 4 comments
Labels
good first issue Good for newcomers pkg/server This is due to an issue in the packages/server directory

Comments

@brian-mann
Copy link
Member

Currently the scaffolded file looks like this...

// ***********************************************************
// This example plugins/index.js can be used to load plugins
//
// You can change the location of this file or turn off loading
// the plugins file with the 'pluginsFile' configuration option.
//
// You can read more here:
// https://on.cypress.io/plugins-guide
// ***********************************************************

// This function is called when a project is opened or re-opened (e.g. due to
// the project's config changing)

module.exports = (on, config) => {
  // `on` is used to hook into various events Cypress emits
  // `config` is the resolved Cypress config
}

I think this puts too much emphasis on "turning off this file" - there's not really even a use case of that, and instead we should maybe list out the available plugin events.

The only problem I see with this is that when this file is scaffolded - it's scaffolded based on the current version of Cypress. As users upgrade Cypress we may release new plugin events but they won't be listed into the commented out code.

@jennifer-shehane jennifer-shehane added the stage: ready for work The issue is reproducible and in scope label Jun 4, 2018
@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane added good first issue Good for newcomers pkg/server This is due to an issue in the packages/server directory labels Jun 4, 2018
@wildaces215
Copy link

Is this open?

@jennifer-shehane
Copy link
Member

@wildaces215 Yes, no work has been done on this.

@jennifer-shehane
Copy link
Member

Since this issue hasn't had activity in a while, we'll close the issue. Please comment if there is new information to provide concerning the original issue and we'd be happy to reopen.

@jennifer-shehane jennifer-shehane removed the stage: ready for work The issue is reproducible and in scope label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers pkg/server This is due to an issue in the packages/server directory
Projects
None yet
Development

No branches or pull requests

4 participants