Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Paths and .zip to Download URLs #17291

Closed
CypressJosh opened this issue Jul 12, 2021 · 6 comments
Closed

Add Paths and .zip to Download URLs #17291

CypressJosh opened this issue Jul 12, 2021 · 6 comments
Assignees

Comments

@CypressJosh
Copy link

CypressJosh commented Jul 12, 2021

What would you like?

  1. Add a path option to our downloads URL that would essentially work the same as the query params, but as paths, ex:
    a. https://download.cypress.io/desktop?platform=OS&arch=ARCH (current)
    b. https://download.cypress.io/desktop/linux-86/binary/ (net new)
  2. Adding .zip to https://download.cypress.io/desktop and supporting both, ex:
    a. https://download.cypress.io/desktop (current)
    b. https://download.cypress.io/desktop.zip (net new)

Why is this needed?

JFrog's Artifactory appears to have a couple limitations preventing users from being able to download Cypress while using Artifactory.

@jennifer-shehane
Copy link
Member

Are these related? #15697, #17238

Whats the error they see when downloading?

@flotwig
Copy link
Contributor

flotwig commented Jul 12, 2021

Someone posted some instructions for Artifactory users: #15697 (comment)

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: to do labels Jul 12, 2021
@amirrustam
Copy link
Contributor

@flotwig #15697 (comment) won't be a sufficient enough solution since many Artificatory users have to store artifacts locally after they are scanned by Artifactory's XRay (vulnerability scanner) system.

@cypress-bot cypress-bot bot added stage: waiting and removed stage: needs review The PR code is done & tested, needs review labels Jul 15, 2021
@jennifer-shehane
Copy link
Member

Someone mentioned wanting to be able to also include the version in the download url. cypress_8.0.0.zip, etc. Mentioning it here since it seems partially related. #17417

@flotwig
Copy link
Contributor

flotwig commented Jul 21, 2021

The following routes have been deployed to download.cypress.io:

  • /desktop.zip
  • /desktop/:platform-:arch/cypress.zip
  • /desktop/:version/:platform-:arch/cypress.zip

@jennifer-shehane
Copy link
Member

The code for this is done, but this has yet to be released. It should be released soon by our API team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants