Cypress test runner redirects to __ suddenly

[joelgrimberg]

I am building an E2E test in which I use a button / submit to go to a second page.
the submit triggers a redirect through jQuery.

I tried using :

Cypress.on('window:before:load', (win) => {
      Object.defineProperty(win, 'self', {
        get: () => {
          return window.top
        }
      })
    })

I also tried using

cy.visit('url', {
			 onBeforeLoad: (win) => {
			 Object.defineProperty(win, 'self', {
			 get: () => {
			 return window.top
		 }

The code as shown above does not work (I still get the 'whoops') for redirects behind buttons;
it only works for redirects behind cy.visit as it looks.

#1064
#392
#969
#992

[brian-mann]

You'll need to find the JS from your site causing the redirect. It is 100% on your application code and likely should be disabled when running in Cypress. It's called framebusting. The fix that you're using only works for framebusting which is checking window.self. There are always ways to implement it like by counting window.frames.length and the easiest thing here is just to remove the JS altogether.

[odranoelBR]

Tks a lot @brian-mann .
I will inpect what works behing the button.

You guys are creating a great tool, keep working and i help / hope it get bigger.

[brian-mann]

Fixed by #1295

[brian-mann]

Released in 2.0.0.

[joelgrimberg]

Great! When will 2.0 be released? Cannot wait ;-) Joël Op 16 februari 2018 om 07:16:18, Brian Mann (notifications@github.com(mailto:notifications@github.com)) schreef:

…

Released in 2.0.0(https://docs.cypress.io/guides/references/changelog.html#2-0-0). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub(#1245 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AC20XkgnszeoAKTatUIIdEbpSRDgqlIfks5tVR0ygaJpZM4R1dry).

[jennifer-shehane]

@joelgrimberg It is released now.