Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cy.visit fails on *.github.io websites due to CORS #1161

Closed
bootstraponline opened this issue Jan 7, 2018 · 4 comments
Closed

cy.visit fails on *.github.io websites due to CORS #1161

bootstraponline opened this issue Jan 7, 2018 · 4 comments
Labels
type: duplicate This issue or pull request already exists
Milestone

Comments

@bootstraponline
Copy link

bootstraponline commented Jan 7, 2018

  • Operating System: Windows 10
  • Cypress Version: 1.4.1
  • Browser Version: Google Chrome Version 63.0.3239.132 (Official Build) (64-bit)

Is this a Feature or Bug?

Feature.

Current behavior:

Cypress is not able to automate *.github.io websites for repos.

Desired behavior:

cy.visit succeeds.

How to reproduce:

Run the test.

Test code:

describe('My First Test', function() {
  it('Does not do much!', function() {
    cy.visit('https://bootstraponline.github.io/hex/')
  })
})

Additional Info (images, stack traces, etc)

image

@brian-mann brian-mann added the type: duplicate This issue or pull request already exists label Jan 8, 2018
@brian-mann
Copy link
Member

The root cause of this is because github.io is on the public suffix which we have to utilize to make these work. There's a couple issues for this already open:

@brian-mann brian-mann added this to the 1.4.2 milestone Feb 4, 2018
brian-mann added a commit that referenced this issue Feb 4, 2018
…ixes #1161

- use the public suffix when parsing tld’s so that document.domain is
set correctly
brian-mann added a commit that referenced this issue Feb 4, 2018
…ixes #1161 (#1256)

- use the public suffix when parsing tld’s so that document.domain is
set correctly
brian-mann added a commit that referenced this issue Feb 4, 2018
* server: fixes #802 and fixes #380 and fixes #402 and fixes #493 and fixes #1161

- use the public suffix when parsing tld’s so that document.domain is
set correctly

* driver: move location spec back into cypress tests

* server, driver: fixes: #600 and fixes #1175 use public suffix for parsing tld, handle multiple different subdomains on cy.visit
@brian-mann
Copy link
Member

brian-mann commented Feb 5, 2018

Released in 1.4.2.

@bootstraponline
Copy link
Author

that link resolves to localhost

@brian-mann
Copy link
Member

Fixed, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants