From 88efc33abaa5219a4c8478d9fb9a43c191271d77 Mon Sep 17 00:00:00 2001 From: Chris Breiding Date: Mon, 20 Nov 2017 20:56:12 -0500 Subject: [PATCH] server: fix missing reject arg and add test (#935) --- packages/server/lib/plugins/index.coffee | 2 +- packages/server/test/unit/plugins/index_spec.coffee | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/server/lib/plugins/index.coffee b/packages/server/lib/plugins/index.coffee index e616967dc9b9..92832b07cc3a 100644 --- a/packages/server/lib/plugins/index.coffee +++ b/packages/server/lib/plugins/index.coffee @@ -28,7 +28,7 @@ module.exports = { init: (config, options) -> log("plugins.init", config.pluginsFile) - new Promise (resolve) -> + new Promise (resolve, reject) -> return resolve() if not config.pluginsFile if pluginsProcess diff --git a/packages/server/test/unit/plugins/index_spec.coffee b/packages/server/test/unit/plugins/index_spec.coffee index a6c245593d97..6d88ac2b831f 100644 --- a/packages/server/test/unit/plugins/index_spec.coffee +++ b/packages/server/test/unit/plugins/index_spec.coffee @@ -80,6 +80,18 @@ describe "lib/plugins/index", -> ) expect(value).to.equal("value") + describe "load:error message", -> + beforeEach -> + @ipc.on.withArgs("load:error").yields("PLUGINS_FILE_ERROR", "path/to/pluginsFile.js", "error message") + + it "rejects plugins.init", -> + plugins.init({ pluginsFile: "cypress-plugin" }) + .catch (err) => + expect(err.message).to.contain("The plugins file is missing or invalid") + expect(err.message).to.contain("path/to/pluginsFile.js") + expect(err.message).to.contain("The following error was thrown") + expect(err.message).to.contain("error message") + describe "error message", -> beforeEach -> @err = {