server: fix missing reject arg and add test (#935)

cypress-io · Nov 21, 2017 · 88efc33 · 88efc33
1 parent 356e306
commit 88efc33
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/server/lib/plugins/index.coffee b/packages/server/lib/plugins/index.coffee
@@ -28,7 +28,7 @@ module.exports = {
   init: (config, options) ->
     log("plugins.init", config.pluginsFile)
 
-    new Promise (resolve) ->
+    new Promise (resolve, reject) ->
       return resolve() if not config.pluginsFile
 
       if pluginsProcess

diff --git a/packages/server/test/unit/plugins/index_spec.coffee b/packages/server/test/unit/plugins/index_spec.coffee
@@ -80,6 +80,18 @@ describe "lib/plugins/index", ->
           )
           expect(value).to.equal("value")
 
+    describe "load:error message", ->
+      beforeEach ->
+        @ipc.on.withArgs("load:error").yields("PLUGINS_FILE_ERROR", "path/to/pluginsFile.js", "error message")
+
+      it "rejects plugins.init", ->
+        plugins.init({ pluginsFile: "cypress-plugin" })
+        .catch (err) =>
+          expect(err.message).to.contain("The plugins file is missing or invalid")
+          expect(err.message).to.contain("path/to/pluginsFile.js")
+          expect(err.message).to.contain("The following error was thrown")
+          expect(err.message).to.contain("error message")
+
     describe "error message", ->
       beforeEach ->
         @err = {