subscriptions only yield on change

[oliver-sanders]

Spotted by @MetRonnie 👀

Subscriptions in GraphiQL only come through when the data is updated.

This was the cause behind #328 (which was never really solved).

E.G. Here I run a subscription, but get no results until I install or remove a workflow.

Note: In order to reproduce you must have no running workflows.

Note: Changing the initialBurst argument makes no difference.

I think this is a bug, yet strangely if I open the UI, my stopped workflows appear in the workflows list so maybe it's just GraphiQL.

Is this how it's meant to work?

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

[hjoliver]

Any ideas on this one @dwsutherland ?

[dwsutherland]

I'm able to reproduce this.. Will look into it, pretty sure it use to work.

I think this is a bug, yet strangely if I open the UI, my stopped workflows appear in the workflows list so maybe it's just GraphiQL.

Perhaps because it starts before the first scan is complete (?), so it gets that change

[dwsutherland]

The deltas entry point does work:

subscription {
  deltas (stripNull: true) {
    id
    updated {
      workflow {
        id
        status
        stateTotals
      }
    }
    added {
      workflow{
        id
        status
        stateTotals
      }
    }
  }
}

Hence why the UI works .. so it's probably the workflows and others

[dwsutherland]

Found it.. it's the ignoreInterval .. this works:

subscription {
  workflows (initialBurst: true, ignoreInterval: 0.0) {
    id
    states
    stateTotals
  }
}

Defaults to 2.5 seconds .. reason being; these entry points dump the entire store (not just the deltas), although they can be made to do deltas (via args)...
If zero it would push the whole store on any delta by default..

I'll make a change so the first always gets through no matter the interval..

[dwsutherland]

fix up.. it's a one liner