Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aoft: expand cycles/families in mutations to the visible selection #686

Open
oliver-sanders opened this issue Jun 7, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Jun 7, 2021

See cylc/cylc-flow#4238 (review)

Tui: sibling cylc/cylc-flow#4246

Task pool commands (e.g. cylc hold) can only apply pattern matching to the n=0 window. This means that cylc hold <family>.<cycle> or cylc hold '*.<cycle>' don't work if <cycle> is not in the n=0 window.

The practical upshot of this is if you try to hold a family or cycle of tasks that are in the n>0 window, then nothing happens.

To get around this problem we should expand the cycle/family to the full list of tasks visible in the UI.

@oliver-sanders
Copy link
Member Author

Adding the bug label as this will cause confusion for users.

This may require a little thought, we don't currently have the ability to expand a family/cycle to its constituent tasks so I think this is closely related to #434.

There is also the problem of knowing when to treat a cycle point as a cycle point and when to expand it to a list of IDs. It may be easier to attempt this after cylc/cylc-flow#4238.

@oliver-sanders oliver-sanders modified the milestones: 0.5.0, 0.6.0 Jul 15, 2021
@oliver-sanders oliver-sanders modified the milestones: 0.6.0, 1.0 Oct 7, 2021
@oliver-sanders oliver-sanders modified the milestones: 1.0, 1.x Feb 7, 2022
@oliver-sanders oliver-sanders modified the milestones: 1.x, Pending Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant