Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cycle time handling and asynchronous tasks #650

Closed
hjoliver opened this issue Aug 19, 2013 · 1 comment
Closed

cycle time handling and asynchronous tasks #650

hjoliver opened this issue Aug 19, 2013 · 1 comment
Assignees
Labels
duplicate This is a duplicate of something else

Comments

@hjoliver
Copy link
Member

Internal handling of cycle times is still a bit of a mess. In the early days, cycle times were simply strings, "YYYYMMDDHH", and were widely used as such throughout the code. Then two complicating things happened:

  1. cycle times became objects with the ability to do some date time arithmetic and to check the validity of their initial date time values. But much of the code that uses them still expects the old string form so there's some messy on-the-fly conversion ... this could be cleaned up. [Edit: task cycle times as still string labels, but a cycle time class is used on-the-fly for date time arithmetic]

  2. asynchronous tasks with an integer tag instead of a cycle time were bolted on to the system. These tags fail cycle time validity tests so we have to be careful to exclude asynchronous tasks from operations that treat them as if they were cycling tasks. Else: Fixed reload of async tasks in mixed suites, and sequential tasks. #637 Future trigger final-cycle check should ignore async tasks. #649

The big upcoming ISO time change will involve a complete overhaul of cycle time handling. We need to ensure that asynchronous and cycling tasks can be handled cleanly without special case tests that can easily be forgotten. The cycle time class(es) should be able to manage the differences in behaviour automatically.

@hjoliver
Copy link
Member Author

Closing this, it is being addressed with #119.

@matthewrmshin matthewrmshin removed this from the later milestone Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This is a duplicate of something else
Projects
None yet
Development

No branches or pull requests

2 participants