Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comms-timeout automated test #4137

Open
datamel opened this issue Mar 19, 2021 · 1 comment
Open

comms-timeout automated test #4137

datamel opened this issue Mar 19, 2021 · 1 comment
Labels
small
Milestone
8.x

Comments

@datamel
Copy link
Contributor

datamel commented Mar 19, 2021 •
edited
Loading

Client.py --comms_timeout currently only manually tested, it would be nice to have this covered by the automated tests.
Add an automated test to ensure --comms_timeout correctly raises ClientTimeout.

Preferably test with python rather than bash.

Flagged whilst working on #4119
@datamel datamel added the small label Mar 19, 2021
@datamel datamel added this to the cylc-8.0b1 milestone Mar 19, 2021
@hjoliver hjoliver modified the milestones: cylc-8.0b1, cylc-8.0b2 Apr 15, 2021
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0b2, cylc-8.0b3 Jul 15, 2021
@oliver-sanders
Copy link
Member

Could be done as an integration test by patching the server method to prevent it from replying.

@hjoliver hjoliver modified the milestones: cylc-8.0b3, cylc-8.x Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small
Projects
None yet
Milestone
8.x
Development

No branches or pull requests
3 participants
@hjoliver @oliver-sanders @datamel