Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh client: add async_request method #4129

Closed
oliver-sanders opened this issue Mar 17, 2021 · 2 comments · Fixed by #4595
Closed

ssh client: add async_request method #4129

oliver-sanders opened this issue Mar 17, 2021 · 2 comments · Fixed by #4595
Assignees
Labels
bug Something is wrong :( small
Milestone

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Mar 17, 2021

Follow on from #4119

Note: Low priority.

Add an async_request method to the SSH client to match the ZMQ client.

async def async_request(self, ...)
    proc = remote_cylc_cmd(...)
    while True:
        if proc.poll():
            break
        await asyncio.sleep(self.SLEEP_INTERVAL)
    ...

This can be used in cylc scan via the get_client abstraction to support the SSH interface in this command.

Pull requests welcome!

@oliver-sanders oliver-sanders added this to the cylc-8.0.0 milestone Mar 17, 2021
@hjoliver hjoliver modified the milestones: cylc-8.0.0, cylc-8.x Aug 4, 2021
@datamel
Copy link
Contributor

datamel commented Jan 19, 2022

Unfortunately UID has caused this to be a breaking change which needs fixing before 8.0rc1. Updating the milestone.

@datamel datamel modified the milestones: cylc-8.x, cylc-8.0rc1 Jan 19, 2022
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Jan 19, 2022
@oliver-sanders
Copy link
Member Author

This has now become a bug, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants