From 9e25d40581ea73d0c4a077b87a9d5b679653e91a Mon Sep 17 00:00:00 2001 From: takahiro-yamada Date: Wed, 2 Oct 2024 02:56:26 +0000 Subject: [PATCH] Fix test to align with controller-runtime changes ref. https://github.com/kubernetes-sigs/controller-runtime/pull/2918 --- controllers/autovirtualdc_controller_test.go | 4 ++++ controllers/virtualdc_controller_test.go | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/controllers/autovirtualdc_controller_test.go b/controllers/autovirtualdc_controller_test.go index dc5d8da..a8ab5ef 100644 --- a/controllers/autovirtualdc_controller_test.go +++ b/controllers/autovirtualdc_controller_test.go @@ -16,6 +16,7 @@ import ( "k8s.io/utils/ptr" ctrl "sigs.k8s.io/controller-runtime" "sigs.k8s.io/controller-runtime/pkg/client" + "sigs.k8s.io/controller-runtime/pkg/config" metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server" ) @@ -39,6 +40,9 @@ var _ = Describe("AutoVirtualDC controller", func() { Scheme: scheme, LeaderElection: false, Metrics: metricsserver.Options{BindAddress: "0"}, + Controller: config.Controller{ + SkipNameValidation: ptr.To(true), + }, }) Expect(err).NotTo(HaveOccurred()) diff --git a/controllers/virtualdc_controller_test.go b/controllers/virtualdc_controller_test.go index 4ebad17..6bd8906 100644 --- a/controllers/virtualdc_controller_test.go +++ b/controllers/virtualdc_controller_test.go @@ -18,8 +18,10 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/types" "k8s.io/apimachinery/pkg/util/intstr" + "k8s.io/utils/ptr" ctrl "sigs.k8s.io/controller-runtime" "sigs.k8s.io/controller-runtime/pkg/client" + "sigs.k8s.io/controller-runtime/pkg/config" metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server" ) @@ -73,6 +75,9 @@ var _ = Describe("VirtualDC controller", func() { Scheme: scheme, LeaderElection: false, Metrics: metricsserver.Options{BindAddress: "0"}, + Controller: config.Controller{ + SkipNameValidation: ptr.To(true), + }, }) Expect(err).NotTo(HaveOccurred())