Skip to content
This repository has been archived by the owner on Jan 29, 2019. It is now read-only.

Kafka and Cassandra integration tests are very unstable #255

Closed
1 task
hleb-albau opened this issue Aug 7, 2018 · 13 comments · Fixed by #268
Closed
1 task

Kafka and Cassandra integration tests are very unstable #255

hleb-albau opened this issue Aug 7, 2018 · 13 comments · Fixed by #268

Comments

@hleb-albau
Copy link
Contributor

hleb-albau commented Aug 7, 2018

Overview

Right now we have a lot of integration tests using embedded kafka and cassandra. The main issue with this tests, that they are very unstable.
See https://circleci.com/gh/cybercongress/workflows/cyber-search


Task description

Integration tests should be stable. 100% builds for right written tests.

Required skills

  • Kotlin
  • Kafka
  • Cassandra
  • Spring
  • JUnit

Contribution rules

Here you can learn how to contribute to our project


Definition of done

Explain what you actually want to see as a result:

  • build should be stable (100% builds for valid project state). Will be tested by executing 100 sequential builds.

Extra information

Bounty amount 0.5 ETH
Experience level advanced
Project length days
Expires in 1 mounth
Bounty type bug
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.5 ETH (185.75 USD @ $371.49/ETH) attached to it.

@mastercyb mastercyb changed the title Kafka and Cassandra Integration Tests is Very Unstable Kafka and Cassandra integration tests are very unstable Aug 26, 2018
@KevinLiLu
Copy link
Contributor

KevinLiLu commented Sep 19, 2018

@hleb-albau

I might be interested in taking this.

Are we constructing the embedded Kafka & Cassandra instances before and after every single test class or are the instances shared for multiple modules?

I'm been browsing the error logs in the CI and it looks like embedded Kafka often has trouble shutting down and closing.

@hleb-albau
Copy link
Contributor Author

hleb-albau commented Sep 20, 2018

Hi @KevinLiLu,

Just start work on gitcoin to show others, that you took this task.

Right now instances are not shared, as far as I remember, but it will be nice, if they do(at least for each module)

@gitcoinbot
Copy link

gitcoinbot commented Oct 4, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 2 months ago.
Please review their action plans below:

1) KevinLiLu has started work.

Will play around with Kafka/Cassandra configurations, and possible use 1 shared instance of Kafka & Cassandra per module.

Learn more on the Gitcoin Issue Details page.

@KevinLiLu
Copy link
Contributor

KevinLiLu commented Oct 4, 2018

@hleb-albau can you grant me write permissions in CircleCI so I can trigger a bunch of builds in a PR to test fail rate? The tests don't really fail on my local so it seems isolated to the CI environment.

@hleb-albau
Copy link
Contributor Author

@KevinLiLu is it possible on CircleCi? I can't found required settings. I generated api token, sent to your email lu.kevin@berkeley.edu.

@KevinLiLu
Copy link
Contributor

KevinLiLu commented Oct 4, 2018

@hleb-albau Ah, a quick google search shows that the permissions are taken from the GitHub repo. So I would need to have write access in this repo in order to run builds...

@hleb-albau
Copy link
Contributor Author

@KevinLiLu try now see

@KevinLiLu
Copy link
Contributor

@hleb-albau got it. it works now, thanks 😄

@frankchen07
Copy link

hey @KevinLiLu - Frank from Gitcoin here, are you still working on this issue?

@KevinLiLu
Copy link
Contributor

@frankchen07 hey Frank, yes this is still ongoing.

#268

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.5 ETH (108.66 USD @ $217.33/ETH) has been submitted by:

  1. @KevinLiLu

@hleb-albau please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.5 ETH (107.31 USD @ $214.61/ETH) attached to this issue has been approved & issued to @KevinLiLu.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants