Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-chart: no TLS configuration for Analytics #5071

Closed
turowicz opened this issue Oct 10, 2022 · 2 comments
Closed

helm-chart: no TLS configuration for Analytics #5071

turowicz opened this issue Oct 10, 2022 · 2 comments
Assignees
Labels

Comments

@turowicz
Copy link

If using cert-manager it is currently impossible to get a LetsEncrypt certificate mounted for the /analytics route. Please add TLS configuration for it's ingress.

@turowicz
Copy link
Author

I'm on nginx. The chart works with it but I guess this feature request is asking a lot. Not sure how you guys want to proceed but the fix is very easy:

{{- if .Values.ingress.tls }}
  tls:
  {{- range .Values.ingress.tls }}
    - hosts:
      {{- range .hosts }}
        - {{ . | quote }}
      {{- end }}
      secretName: {{ .secretName }}
  {{- end }}
{{- end }}

Add the above in front of rules: in templates/analytics/ingress.yaml

@azhavoro azhavoro added the enhancement New feature or request label Oct 22, 2022
@nmanovic nmanovic added infra and removed enhancement New feature or request labels Jan 4, 2023
@azhavoro
Copy link
Contributor

Fixed in #7132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants