Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Percussion Sample to Music21 Corpus Demo Section #1609

Closed
kir12 opened this issue Jun 15, 2023 · 1 comment · Fixed by #1610
Closed

Add Percussion Sample to Music21 Corpus Demo Section #1609

kir12 opened this issue Jun 15, 2023 · 1 comment · Fixed by #1610

Comments

@kir12
Copy link
Contributor

kir12 commented Jun 15, 2023

Motivation
Currently (as established in this music21 Google Groups post) there aren't any scores inside the music21 corpus that have Percussion parts, since all the pieces in the corpus (as well as probably all eligible pieces) are old enough that Percussion/Drumset parts hadn't really existed yet. Having at least one reference for what a Percussion part in MusicXML should look like for maximum compatibility with music21 would be great for verifying the correctness of our own MusicXML files. (As well as pre-emptively ruling out music21 as the source of any problems)

Feature summary
The aim of this feature is to add this MusicXML sample coming directly from the W3C Community Group (which created the MusicXML spec) to the music21 corpus. It's likely the most authoritative a MusicXML example for Percussion parts can get, and the MusicXML Specification's license seems to allow usages such as this.

Proposed implementation
A file titled drum_sample.xml will be placed in music21/corpus/demos/drum_sample.xml which will have the contents of the MusicXML example.

Intent

[x] I plan on implementing this myself.
[ ] I am willing to pay to have this feature added.
[ ] I am starting a discussion with the hope that community members will volunteer their time to create this. I understand that individuals work on features of interest to them and that this feature may never be implemented.

@mscuthbert
Copy link
Member

Good issue. Glad to take a commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants