From 23f51a691cf211a61135e90dd3752869ed1eb208 Mon Sep 17 00:00:00 2001 From: Oliver Wolff <23139298+cuioss@users.noreply.github.com> Date: Tue, 18 Feb 2025 09:59:23 +0100 Subject: [PATCH] IDE-Checks --- .../de/cuioss/uimodel/field/DynamicFieldType.java | 2 +- src/main/java/de/cuioss/uimodel/model/Gender.java | 2 +- ...yConstans.java => AugmentationKeyConstants.java} | 13 ++++++------- .../uimodel/model/conceptkey/ConceptCategory.java | 2 +- .../model/conceptkey/impl/BaseConceptCategory.java | 4 ++-- .../uimodel/nameprovider/DisplayMessageFormat.java | 2 +- src/site/asciidoc/about.adoc | 2 +- .../conceptkey/impl/ConceptCategoryGenerator.java | 4 ++-- 8 files changed, 15 insertions(+), 16 deletions(-) rename src/main/java/de/cuioss/uimodel/model/conceptkey/{AugmentationKeyConstans.java => AugmentationKeyConstants.java} (87%) diff --git a/src/main/java/de/cuioss/uimodel/field/DynamicFieldType.java b/src/main/java/de/cuioss/uimodel/field/DynamicFieldType.java index 24ce23c..416f0c0 100644 --- a/src/main/java/de/cuioss/uimodel/field/DynamicFieldType.java +++ b/src/main/java/de/cuioss/uimodel/field/DynamicFieldType.java @@ -133,7 +133,7 @@ public boolean isBooleanField() { * @return {@link DynamicFieldType} identified by the given type. In case there * is no fitting type it will return {@link DynamicFieldType#STRING} */ - public static final DynamicFieldType getByTypeString(final String type) { + public static DynamicFieldType getByTypeString(final String type) { var fieldType = DynamicFieldType.STRING; for (final DynamicFieldType dynamicFieldType : DynamicFieldType.values()) { diff --git a/src/main/java/de/cuioss/uimodel/model/Gender.java b/src/main/java/de/cuioss/uimodel/model/Gender.java index 204b6eb..3952df2 100644 --- a/src/main/java/de/cuioss/uimodel/model/Gender.java +++ b/src/main/java/de/cuioss/uimodel/model/Gender.java @@ -109,7 +109,7 @@ private static Map initMapping() { * @param genderString may be {@code null} or empty * @return the computed {@linkplain Gender} object. */ - public static final Gender fromString(final String genderString) { + public static Gender fromString(final String genderString) { final var key = nullToEmpty(genderString).toLowerCase(); return MAPPING.getOrDefault(key, UNKNOWN); } diff --git a/src/main/java/de/cuioss/uimodel/model/conceptkey/AugmentationKeyConstans.java b/src/main/java/de/cuioss/uimodel/model/conceptkey/AugmentationKeyConstants.java similarity index 87% rename from src/main/java/de/cuioss/uimodel/model/conceptkey/AugmentationKeyConstans.java rename to src/main/java/de/cuioss/uimodel/model/conceptkey/AugmentationKeyConstants.java index ae4579a..6a47f90 100644 --- a/src/main/java/de/cuioss/uimodel/model/conceptkey/AugmentationKeyConstans.java +++ b/src/main/java/de/cuioss/uimodel/model/conceptkey/AugmentationKeyConstants.java @@ -23,11 +23,10 @@ * @author Matthias Walliczek */ @UtilityClass -public final class AugmentationKeyConstans { +public final class AugmentationKeyConstants { /** - * Marks one code in a category as default, e.g. to be used to preselect a drop - * down box. + * Marks one code in a category as default, e.g., to be used to preselect a drop-down box. */ public static final String DEFAULT_VALUE = "default_value"; @@ -43,8 +42,8 @@ public final class AugmentationKeyConstans { * true. */ public static boolean isUndefinedValue(final ConceptKeyType codeType) { - return null != codeType && null != codeType.get(AugmentationKeyConstans.UNDEFINED_VALUE) - && Boolean.parseBoolean(codeType.get(AugmentationKeyConstans.UNDEFINED_VALUE)); + return null != codeType && null != codeType.get(AugmentationKeyConstants.UNDEFINED_VALUE) + && Boolean.parseBoolean(codeType.get(AugmentationKeyConstants.UNDEFINED_VALUE)); } /** @@ -54,7 +53,7 @@ public static boolean isUndefinedValue(final ConceptKeyType codeType) { * true. */ public static boolean isDefaultValue(final ConceptKeyType codeType) { - return null != codeType && null != codeType.get(AugmentationKeyConstans.DEFAULT_VALUE) - && Boolean.parseBoolean(codeType.get(AugmentationKeyConstans.DEFAULT_VALUE)); + return null != codeType && null != codeType.get(AugmentationKeyConstants.DEFAULT_VALUE) + && Boolean.parseBoolean(codeType.get(AugmentationKeyConstants.DEFAULT_VALUE)); } } diff --git a/src/main/java/de/cuioss/uimodel/model/conceptkey/ConceptCategory.java b/src/main/java/de/cuioss/uimodel/model/conceptkey/ConceptCategory.java index b45d2a0..224ca93 100644 --- a/src/main/java/de/cuioss/uimodel/model/conceptkey/ConceptCategory.java +++ b/src/main/java/de/cuioss/uimodel/model/conceptkey/ConceptCategory.java @@ -34,7 +34,7 @@ public interface ConceptCategory extends Serializable { /** * @param value the identifier * @return an ConceptKeyType with given value marked with - * {@link AugmentationKeyConstans#UNDEFINED_VALUE} + * {@link AugmentationKeyConstants#UNDEFINED_VALUE} */ ConceptKeyType createUndefinedConceptKey(String value); } diff --git a/src/main/java/de/cuioss/uimodel/model/conceptkey/impl/BaseConceptCategory.java b/src/main/java/de/cuioss/uimodel/model/conceptkey/impl/BaseConceptCategory.java index 3c4feb7..d817373 100644 --- a/src/main/java/de/cuioss/uimodel/model/conceptkey/impl/BaseConceptCategory.java +++ b/src/main/java/de/cuioss/uimodel/model/conceptkey/impl/BaseConceptCategory.java @@ -17,7 +17,7 @@ import java.io.Serial; -import de.cuioss.uimodel.model.conceptkey.AugmentationKeyConstans; +import de.cuioss.uimodel.model.conceptkey.AugmentationKeyConstants; import de.cuioss.uimodel.model.conceptkey.ConceptCategory; import de.cuioss.uimodel.model.conceptkey.ConceptKeyType; import de.cuioss.uimodel.nameprovider.I18nDisplayNameProvider; @@ -60,7 +60,7 @@ public BaseConceptCategory(final String name) { @Override public ConceptKeyType createUndefinedConceptKey(final String value) { return ConceptKeyTypeImpl.builder().identifier(value).labelResolver(new I18nDisplayNameProvider(value)) - .category(this).augmentation(AugmentationKeyConstans.UNDEFINED_VALUE, Boolean.TRUE.toString()).build(); + .category(this).augmentation(AugmentationKeyConstants.UNDEFINED_VALUE, Boolean.TRUE.toString()).build(); } } diff --git a/src/main/java/de/cuioss/uimodel/nameprovider/DisplayMessageFormat.java b/src/main/java/de/cuioss/uimodel/nameprovider/DisplayMessageFormat.java index ad6eaa4..67a839c 100644 --- a/src/main/java/de/cuioss/uimodel/nameprovider/DisplayMessageFormat.java +++ b/src/main/java/de/cuioss/uimodel/nameprovider/DisplayMessageFormat.java @@ -144,7 +144,7 @@ public DisplayMessageProvider build() { /** * @return {@linkplain Builder} in fluent api style */ - public static final Builder builder() { + public static Builder builder() { return new Builder(); } } diff --git a/src/site/asciidoc/about.adoc b/src/site/asciidoc/about.adoc index c4d6775..31e32a1 100644 --- a/src/site/asciidoc/about.adoc +++ b/src/site/asciidoc/about.adoc @@ -1,3 +1,3 @@ == About -Defines types and stuctures symplifying the integration of server-side ui \ No newline at end of file +Defines types and features simplifying the integration of server-side ui \ No newline at end of file diff --git a/src/test/java/de/cuioss/uimodel/model/conceptkey/impl/ConceptCategoryGenerator.java b/src/test/java/de/cuioss/uimodel/model/conceptkey/impl/ConceptCategoryGenerator.java index 0a88683..793253b 100644 --- a/src/test/java/de/cuioss/uimodel/model/conceptkey/impl/ConceptCategoryGenerator.java +++ b/src/test/java/de/cuioss/uimodel/model/conceptkey/impl/ConceptCategoryGenerator.java @@ -17,7 +17,7 @@ import de.cuioss.test.generator.Generators; import de.cuioss.test.generator.TypedGenerator; -import de.cuioss.uimodel.model.conceptkey.AugmentationKeyConstans; +import de.cuioss.uimodel.model.conceptkey.AugmentationKeyConstants; import de.cuioss.uimodel.model.conceptkey.ConceptCategory; import de.cuioss.uimodel.model.conceptkey.ConceptKeyType; @@ -42,7 +42,7 @@ enum TestCodeCategory implements ConceptCategory { @Override public ConceptKeyType createUndefinedConceptKey(final String value) { return ConceptKeyTypeImpl.builder().category(this).identifier(value) - .augmentation(AugmentationKeyConstans.UNDEFINED_VALUE, Boolean.TRUE.toString()).build(); + .augmentation(AugmentationKeyConstants.UNDEFINED_VALUE, Boolean.TRUE.toString()).build(); } @Override