Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_lazy_zarr_array is failing with latest zarr-python v3 #618

Closed
tomwhite opened this issue Nov 15, 2024 · 2 comments
Closed

test_lazy_zarr_array is failing with latest zarr-python v3 #618

tomwhite opened this issue Nov 15, 2024 · 2 comments
Labels
bug Something isn't working upstream Involves changes to an upstream library zarr

Comments

@tomwhite
Copy link
Member

From https://github.com/cubed-dev/cubed/actions/runs/11855798688/job/33040762855?pr=617:

    def test_lazy_zarr_array(tmp_path):
        zarr_path = tmp_path / "lazy.zarr"
        arr = lazy_zarr_array(zarr_path, shape=(3, 3), dtype=int, chunks=(2, 2))
    
        assert not zarr_path.exists()
>       with pytest.raises((FileNotFoundError, TypeError, ValueError)):
E       Failed: DID NOT RAISE (<class 'FileNotFoundError'>, <class 'TypeError'>, <class 'ValueError'>)

Running git bisect shows that this change in Zarr is the cause: zarr-developers/zarr-python#2442

@tomwhite tomwhite added zarr upstream Involves changes to an upstream library bug Something isn't working labels Nov 15, 2024
@tomwhite
Copy link
Member Author

Opened zarr-developers/zarr-python#2491

@tomwhite
Copy link
Member Author

Fixed upstream in zarr-developers/zarr-python#2494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Involves changes to an upstream library zarr
Projects
None yet
Development

No branches or pull requests

1 participant