Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of BOOL for TINYINT Column Type #2981

Closed
bhsmither opened this issue Apr 25, 2022 · 1 comment
Closed

Use of BOOL for TINYINT Column Type #2981

bhsmither opened this issue Apr 25, 2022 · 1 comment
Assignees
Milestone

Comments

@bhsmither
Copy link
Contributor

In CubeCart->getDocument(), near line 155, there is this in the statement:

array('doc_home' => true, 'doc_status' => '1')

The schema for CubeCart_documents.doc_home is a data type of tinyint. While true does resolve to a non-zero-ish value (non-strict), there is trouble on the horizon.

PHP 8.1 says: Argument of type bool for ctype_alnum() will be interpreted as string in the future." (This relates to Database->where() near line 926:

if (isset($value) && !ctype_alnum($value) || $value=='NULL' || is_null($value) || $value=='NOT NULL') {

Suggest:

array('doc_home' => '1', 'doc_status' => '1')
@abrookbanks abrookbanks self-assigned this Jun 13, 2022
@abrookbanks
Copy link
Member

Resolved as part of #2708 Thanks!

@abrookbanks abrookbanks added this to the 6.4.6 milestone Jun 13, 2022
@abrookbanks abrookbanks added duplicate and removed bug labels Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants