Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only terminal response codes for x-ms-long-running-operation's #7

Closed
wants to merge 3 commits into from

Conversation

ctaggart
Copy link
Owner

@ctaggart ctaggart commented Feb 2, 2021

These changes pass all of the validation:

autorest --validation --azure-validator --use=@microsoft.azure/classic-openapi-validator@latest --use=@microsoft.azure/openapi-validator@latest --tag=package-2021-01-01-preview specification\vmware\resource-manager\readme.md
oav validate-spec specification\vmware\resource-manager\Microsoft.AVS\preview\2021-01-01-preview\vmware.json -p
oav validate-example specification\vmware\resource-manager\Microsoft.AVS\preview\2021-01-01-preview\vmware.json -p

I do not think we are supposed to put the async response codes in the spec. I think we are supposed to have the response codes for when the operation reaches its terminal provisioning state.

This pull request is still in progress. I have not updated every affected operation.

@ctaggart
Copy link
Owner Author

ctaggart commented Feb 4, 2021

I was wrong. The generated python code is checking the response codes from both the initial request and the polled requests against the set of response codes.

@ctaggart ctaggart closed this Feb 4, 2021
@ctaggart ctaggart deleted the terminal-response-codes branch February 4, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants