CreateOCMShareRequest.Protocol vs CreateOCMShareRequest.Opaque.Map["protocol"]

[michielbdejong]

Looking at this definition it seems that CreateOCMShare requests have a Protocol field.

But looking at this server code and this client code it seems that the protocol is put into the root opaque instead?

Is this intentional?

CC @redblom

[michielbdejong]

If not I can easily switch it around, let me know.

I'm adding the req.protocol.options.sharedSecret from https://cs3org.github.io/OCM-API/docs.html#/paths/~1shares/post which is needed for the webdav protocol and wanted to put it into CreateOCMShareRequest.Protocol but then I noticed your use of CreateOCMShareRequest.Opaque.Map["protocol"] and thought I should probably check first. :)

[michielbdejong]

Ah wait,
it's https://cs3org.github.io/cs3apis/#cs3.sharing.ocm.v1beta1.CreateOCMShareRequest
not https://cs3org.github.io/cs3apis/#cs3.ocm.core.v1beta1.CreateOCMCoreShareRequest
Never mind! :)