+(-1 - 1.i) return (1 +1.i)

[cristian-lsdb]

Adding + in front of a complex number return a new complex with a positive value of the real and imaginary part.

require "complex"
pp! +( 1 + 1.i) # => (1.0 + 1.0i)
pp! +(-1 + 1.i) # => (1.0 + 1.0i)
pp! +( 1 - 1.i) # => (1.0 + 1.0i)
pp! +(-1 - 1.i) # => (1.0 + 1.0i)

This is caused by the instance method Complex#+

In Ruby, Python and C++, +(-1 - 1i) return (-1 - 1i).

[naqvis]

Complex.+ methods returns the absolute value of self. Believe you are treating or expecting it to behave like normal unary operator on other primitives. Please refer to API documentation

[asterite]

@naqvis That's how it works but I think + should always return self. I'll fix this now.

[naqvis]

Thanks @asterite. One question after change though: shouldn't it return a copy instead of returning self?

[asterite]

It's a struct (a copy is naturally returned) and it's immutable so a copy is never necessary (if it were a class).

[jhass]

It looks like Complex#+ was added by @Sija through #5440. Was there any reasoning for the current implementation?

[Sija]

@jhass Can't remember.