Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs failure with libyaml 0.2.2 #7548

Closed
bcardiff opened this issue Mar 14, 2019 · 1 comment
Closed

Specs failure with libyaml 0.2.2 #7548

bcardiff opened this issue Mar 14, 2019 · 1 comment
Assignees
Labels
good first issue This is an issue suited for newcomers to become aquianted with working on the codebase. kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs

Comments

@bcardiff
Copy link
Member

bcardiff commented Mar 14, 2019

Extracted from https://circleci.com/gh/crystal-lang/crystal/20015

Failures:

  1) YAML serialization to_yaml does for bytes
     Failure/Error: "hello".to_slice.to_yaml.should eq("--- !!binary 'aGVsbG8=\n\n'\n")

       Expected: "--- !!binary 'aGVsbG8=\n\n'\n"
            got: "--- !!binary 'aGVsbG8=\n\n  '\n"

     # spec/std/yaml/serialization_spec.cr:335

Finished in 1:33 minutes
6890 examples, 1 failures, 0 errors, 4 pending

Failed examples:

crystal spec spec/std/yaml/serialization_spec.cr:334 # YAML serialization to_yaml does for bytes

Ref: In the past #6287 solved compatibility with 0.2.1

@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. good first issue This is an issue suited for newcomers to become aquianted with working on the codebase. kind:specs labels Mar 14, 2019
@straight-shoota
Copy link
Member

straight-shoota commented Mar 14, 2019

For reference: this seems to be yaml/libyaml#119

Should be easy to fix using YAML.libyaml_version like in #6287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This is an issue suited for newcomers to become aquianted with working on the codebase. kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs
Projects
None yet
Development

No branches or pull requests

3 participants