Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uknown key in access token json: id_token #4437

Closed
msa7 opened this issue May 20, 2017 · 4 comments
Closed

Uknown key in access token json: id_token #4437

msa7 opened this issue May 20, 2017 · 4 comments
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib
Milestone

Comments

@msa7
Copy link

msa7 commented May 20, 2017

I try to use OAuth2 with Google

    oauth2_client = OAuth2::Client.new(
      "www.googleapis.com",
      client_id,
      client_secret,
      token_uri: "/oauth2/v4/token",
      redirect_uri: redirect_uri
    )

    oauth2_client.get_access_token_using_authorization_code(authorization_code)

Regarding this page, section Exchange authorization code for refresh and access tokens

Note: Your application should ignore any unrecognized fields included in the response.

here

Uknown key in access token json: id_token (Exception)
0x69c7a7: new at /opt/crystal/src/oauth2/access_token/access_token.cr 24:9
@msa7
Copy link
Author

msa7 commented May 20, 2017

I will try to remove raise of exception and send PR if it works with google

@asterite
Copy link
Member

@msa7 Don't worry, I'll fix it in some minutes

@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib labels May 20, 2017
@asterite asterite added this to the Next milestone May 20, 2017
@msa7
Copy link
Author

msa7 commented May 20, 2017

ah... I want my first commit to Crystal :-)
Thanks

@RX14
Copy link
Contributor

RX14 commented May 20, 2017

@msa7 There's an issue label for some simple low-hanging issues to get started contributing to crystal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib
Projects
None yet
Development

No branches or pull requests

3 participants