Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle react-addons-perf? #5

Open
JamieMason opened this issue Apr 20, 2016 · 1 comment
Open

Bundle react-addons-perf? #5

JamieMason opened this issue Apr 20, 2016 · 1 comment

Comments

@JamieMason
Copy link

Hey, thanks for creating this extension.

I wondered if, similar to how Immutable.js Object Formatter bundles immutable-devtools, do you think it could be worthwhile for chrome-react-perf to bundle react-addons-perf?

Thanks a lot,

Jamie

@crysislinux
Copy link
Owner

Thanks for the advice.

It's better to keep react-addons-perf the same version as react. APIs may change between versions. Bundle react-addons-perf in the app is the simplest way to ensure that.

react-addons-perf can be stripped out in production with

if (NODE_ENV !== 'production') {
   require('expose?Perf!react-addons-perf');
}

I will look into that extension and the source of react-addons-perf, to see whether there is a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants