Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename notificationMessages and validationMessages #35

Closed
agrancaric opened this issue Mar 11, 2022 · 0 comments · Fixed by #51
Closed

Rename notificationMessages and validationMessages #35

agrancaric opened this issue Mar 11, 2022 · 0 comments · Fixed by #51
Assignees
@agrancaric
Labels
enhancement New feature or request

Comments

@agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-notification, nrich-validation

Additional information

Enhancement description

Currently the files that contain messages are called notificationMessages and validationMessages. Change camel case to kebab case and add nrich prefix. The new names should be nrich-notification-messages and nrich-validation-messages

Current behaviour

Wanted behaviour

Possible workarounds
@agrancaric agrancaric added the enhancement New feature or request label Mar 11, 2022
@agrancaric agrancaric self-assigned this Mar 18, 2022
@agrancaric agrancaric mentioned this issue Mar 18, 2022
Merged
6 tasks
@agrancaric agrancaric linked a pull request Mar 18, 2022 that will close this issue
Feature rename message files #51
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agrancaric agrancaric

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature rename message files croz-ltd/nrich
1 participant
@agrancaric