-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SetReadDeadline is invalid for pty read, it will block #174
Comments
Would you have more details? context? way to reproduce? |
eg ptmx.SetReadDeadline(time.Now().Add(time.Second))
ptmx.Read(buf) i set the read deadline one second, but if there is no new msg, the read will always block |
On what go version, what os/arch? |
Note that v1.1.21 reverted the non-block behavior introduced by #167, all os are now blocking, which mean SetReadDeadline will not work.
While there is nothing we can do about windows, if you believe it is really important, maybe we could add an optional flag or a different public method to use non-block on OSX and Linux. Closing for now as it is an expected behavior. |
No description provided.
The text was updated successfully, but these errors were encountered: