You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Code duplication: Importantly, I don't understand why the trait bias_v is even needed, given that it duplicates the value stored in std::numeric_limits<...>::digits/digits10/maxdigits10. Same story with the emin_v and emax_v traits compared to the std::numeric_limits<...>::min_exponent/min_exponent10 and std::numeric_limits<...>::max_exponent/max_exponent10. This seems like some code duplication that would be prone to causing confusion later. Why do multiple definitions of traits exist that have the same values? There may be other cases of this as well. I would love to see either std::numeric_limits versions being defined in terms of the other traits where possible, or vice-versa. I find it confusing to have 2 bespoke definitions.
The text was updated successfully, but these errors were encountered:
Code duplication: Importantly, I don't understand why the trait
bias_v
is even needed, given that it duplicates the value stored instd::numeric_limits<...>::digits
/digits10
/maxdigits10
. Same story with theemin_v
andemax_v
traits compared to thestd::numeric_limits<...>::min_exponent
/min_exponent10
andstd::numeric_limits<...>::max_exponent
/max_exponent10
. This seems like some code duplication that would be prone to causing confusion later. Why do multiple definitions of traits exist that have the same values? There may be other cases of this as well. I would love to see eitherstd::numeric_limits
versions being defined in terms of the other traits where possible, or vice-versa. I find it confusing to have 2 bespoke definitions.The text was updated successfully, but these errors were encountered: