Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost Review: Remove Code duplication #843

Open
jzmaddock opened this issue Jan 29, 2025 · 0 comments
Open

Boost Review: Remove Code duplication #843

jzmaddock opened this issue Jan 29, 2025 · 0 comments
Labels
Boost Review Collected Comments from Boost Review Period

Comments

@jzmaddock
Copy link

Code duplication: comparison operators calling into equal_parts_impl() for decimal32_fast, but the definition being placed directly into the comparison operator functions for decimal64_fast and decimal128_fast`. For me, this makes it seem like these 3 types must be implementing the comparison operators in different ways, when in reality they are doing exactly the same calculation, implemented in 3 separate places.
@mborland mborland added the Boost Review Collected Comments from Boost Review Period label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Boost Review Collected Comments from Boost Review Period
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mborland @jzmaddock