Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[health 10.2.0] Remove references to deprecated v1 Android embedding #1017

Closed
reidbaker opened this issue Aug 8, 2024 · 2 comments · Fixed by #1021
Closed

[health 10.2.0] Remove references to deprecated v1 Android embedding #1017

reidbaker opened this issue Aug 8, 2024 · 2 comments · Fixed by #1021
Assignees
Labels
improvement an improvement

Comments

@reidbaker
Copy link

Remove references to deprecated v1 Android embedding

To ensure this plugin will work with users running the next stable version of Flutter remove references to the v1 embedding.

The v1 embedding was deprecated around 6 and a half years ago. In Flutter 3.22, the Flutter tool dropped support for building v1 apps entirely. Flutter plans to delete version one of it's Android embedding in the next stable release, per https://medium.com/flutter/whats-new-in-flutter-3-22-fbde6c164fe3 (in the "Removal of v1 Android embedding" section).

When that deletion happens, any apps using plugins that still have references to the removed classes will fail to build when updating to the next stable version (probably Flutter 3.26).

As a part of this deprecation, the Flutter Android team is doing community outreach by filing bugs and submitting some pull requests to update plugins to minimize the impact this removal has on the community.

Some example PRs:

Consequences:

  • This change should have no impact on users of this plugin that are building apps using the v2 embedding (we don't have a percentage to share, but this is the vast majority of users).
  • It will remove support for users that are still using the v1 embedding on versions of Flutter older than 3.22.

If this change doesn't land, this plugin will instead be broken for all apps building on the next stable version of Flutter and beyond.

Is there a way to support both v1 and v2 embedding apps in the next stable version of Flutter?

No.

This is the PR where we are removing the deprecated engine classes: flutter/engine#52022

@reidbaker
Copy link
Author

reidbaker commented Aug 30, 2024

My query shows that all the code health references are gone.
https://github.com/search?q=repo%3Acph-cachet%2Fflutter-plugins%20(%22io.flutter.view.FlutterMain%22%20OR%20%22io.flutter.view.FlutterNativeView%22%20OR%20%22io.flutter.view.FlutterView%22%20OR%20%22io.flutter.embedding.engine.plugins.shim%22%20OR%20%22io.flutter.app%22%20OR%20%22PluginRegistry.Registrar%22)&type=code

You still have one comment in health and it looks like 2-3 other plugins that are affected. I only filed issues against the top 1000 plugins so it is possible those plugins are not as popular and didnt get bugs.

@SlimShadyIAm
Copy link
Contributor

Thanks @reidbaker! We will ensure that the rest removed as well - the health package is the highest priority for us at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants