Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update crate::database::trade::trades() function #2993

Closed
sunce86 opened this issue Sep 16, 2024 · 1 comment
Closed

feat: Update crate::database::trade::trades() function #2993

sunce86 opened this issue Sep 16, 2024 · 1 comment
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Sep 16, 2024

Problem

Related to #2830 (comment)

This function needs to be updated so that it fetches trades that are relevant for the specific settlement in cases when multiple settlements can exist in a single block in a single environment.
@sunce86 sunce86 added the E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details label Sep 16, 2024
@sunce86 sunce86 mentioned this issue Sep 16, 2024
Closed
@sunce86
Copy link
Contributor Author

sunce86 commented Sep 27, 2024

After double checking the code, I realized the code doesn't need to be adjusted. It already supports multiple trade/settlement events per block.

@sunce86 sunce86 closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunce86