Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor packet data unmarshalling to use specific version #6353

Closed
3 tasks
chatton opened this issue May 22, 2024 · 0 comments
Closed
3 tasks

Refactor packet data unmarshalling to use specific version #6353

chatton opened this issue May 22, 2024 · 0 comments
Assignees
@chatton
Milestone
ICS20 v2 (multi d...

Comments

@chatton
Copy link
Contributor

chatton commented May 22, 2024

Summary

The PoC of ICS20-V2 used a brute force approach where the bytes would be unmarshalled into either a V1 or V2 packet data. We instead want to specifically choose the version based the port and channelId.

This is dependent on #6341

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chatton chatton added this to the ICS20 v2 (multi denom) alpha milestone May 22, 2024
@chatton chatton added this to ibc-go May 22, 2024
@chatton chatton added priority PRs that need prompt reviews and removed priority PRs that need prompt reviews labels May 22, 2024
@chatton chatton self-assigned this May 22, 2024
@chatton chatton mentioned this issue May 22, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega moved this to In progress 👷 in ibc-go May 22, 2024
@chatton chatton closed this as completed May 23, 2024
@github-project-automation github-project-automation bot moved this from In progress 👷 to Done 🥳 in ibc-go May 23, 2024
@coderabbitai coderabbitai bot mentioned this issue May 31, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
None yet
Projects
ibc-go
Archived in project
Milestone
ICS20 v2 (multi denom) alpha
Development

No branches or pull requests
1 participant
@chatton