Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move solo machine client state initialize logic into client module implementation #5974

Closed
3 tasks
colin-axner opened this issue Mar 12, 2024 · 1 comment · Fixed by #6037
Closed
3 tasks
Assignees
Milestone

Comments

@colin-axner
Copy link
Contributor

Summary

Once #5806 is merged to main, it makes sense to move over the solo machine client state Initialize implementation into the light client module implementation as it is quite basic. It asserts that the provided consensus state matches the consensus state in the client state state and the sets the client state to store


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner moved this to On hold ❌ in ibc-go Mar 12, 2024
@crodriguezvega crodriguezvega moved this from On hold ❌ to Todo 🏃 in ibc-go Mar 17, 2024
@crodriguezvega crodriguezvega added this to the v9.0.0 milestone Mar 17, 2024
@DimitrisJim DimitrisJim self-assigned this Mar 20, 2024
@DimitrisJim
Copy link
Contributor

Worth pointing out that multiple of solomachine's impls can be folded into the light client functions now.

In addition to that, we can also very easily make all these previously exported functions private (Assumption would be API is now defined on the light client module interface and the now trimmed down ClientState one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants