Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 08-wasm globals #5833

Closed
3 tasks
colin-axner opened this issue Feb 13, 2024 · 1 comment · Fixed by #6088
Closed
3 tasks

Remove 08-wasm globals #5833

colin-axner opened this issue Feb 13, 2024 · 1 comment · Fixed by #6088
Assignees
@DimitrisJim
Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
v9.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Following merge of #5806 the globals within 08-wasm can be moved to the LightClientModule type. It should be all the types within here

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 08-wasm labels Feb 13, 2024
@colin-axner colin-axner mentioned this issue Feb 15, 2024
Open
3 tasks
@crodriguezvega crodriguezvega moved this to Todo 🏃 in ibc-go Feb 19, 2024
@crodriguezvega crodriguezvega added this to the v9.0.0 milestone Mar 17, 2024
@DimitrisJim DimitrisJim self-assigned this Mar 20, 2024
@DimitrisJim DimitrisJim mentioned this issue Mar 20, 2024
Closed
3 tasks
@crodriguezvega crodriguezvega mentioned this issue Apr 9, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega moved this from Todo 🏃 to In review 👀 in ibc-go Apr 9, 2024
@DimitrisJim DimitrisJim mentioned this issue Apr 10, 2024
Merged
10 tasks
@crodriguezvega
Copy link
Contributor

Closed by #6103

@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Apr 10, 2024
@coderabbitai coderabbitai bot mentioned this issue Apr 17, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
v9.0.0
Development

Successfully merging a pull request may close this issue.

Refactor 08-wasm with improvements after 02-client refactor cosmos/ibc-go
3 participants
@crodriguezvega @DimitrisJim @colin-axner