Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check to make sure upgrade sequences of both channel ends are in sync after ChanUpgradeTry succeeds #5299

Closed
charleenfei opened this issue Dec 4, 2023 · 3 comments
Closed

add check to make sure upgrade sequences of both channel ends are in sync after ChanUpgradeTry succeeds #5299

charleenfei opened this issue Dec 4, 2023 · 3 comments
Labels
channel-upgradability Channel upgradability feature testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@charleenfei
Copy link
Contributor

we are missing a check to make sure that the upgrade sequences of both channel ends are in sync after ChannelUpgradeTry succeeds. If you add after this line a check like this suite.Require().Equal(path.EndpointA.GetChannel().UpgradeSequence, path.EndpointB.GetChannel().UpgradeSequence) you will see that this test will fail.

Originally posted by @crodriguezvega in #5231 (comment)
@crodriguezvega crodriguezvega added testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces channel-upgradability Channel upgradability feature labels Dec 4, 2023
@damiannolan
Copy link
Contributor

is this issue necessary? should this not be addressed in the open PR?

@charleenfei
Copy link
Contributor Author

sure, I can just try to wrap up that PR!

@charleenfei charleenfei mentioned this issue Dec 8, 2023
Merged
9 tasks
@colin-axner
Copy link
Contributor

closed by #5231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
channel-upgradability Channel upgradability feature testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@damiannolan @crodriguezvega @charleenfei @colin-axner