Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof in MsgChannelUpgradeCancel is allowed to be empty (gov override) #5229

Closed
Tracked by #5201
chatton opened this issue Nov 29, 2023 · 1 comment
Closed
Tracked by #5201

Proof in MsgChannelUpgradeCancel is allowed to be empty (gov override) #5229

chatton opened this issue Nov 29, 2023 · 1 comment
Assignees
@chatton

Comments

@chatton
Copy link
Contributor

chatton commented Nov 29, 2023 •
edited
Loading

Proof in MsgChannelUpgradeCancel is allowed to be empty (gov override), so remove this check in ValidateBasic.
@chatton chatton mentioned this issue Nov 29, 2023
Closed
@chatton chatton changed the title Proof in MsgChannelUpgradeCancel is allowed to be empty (gov override), so remove [this check](https://github.com/cosmos/ibc-go/blob/39df8d2b579fc623a1e748b4330738ff40adb682/modules/core/04-channel/types/msgs.go#L850) in ValidateBasic. Proof in MsgChannelUpgradeCancel is allowed to be empty (gov override) Nov 29, 2023
@chatton chatton self-assigned this Nov 29, 2023
@chatton chatton mentioned this issue Nov 29, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim moved this to In review in ibc-go Nov 29, 2023
@DimitrisJim
Copy link
Contributor

done in #5232

@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
None yet
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chatton @DimitrisJim