Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 02-client keeper to use testing pkg #4013

Open
3 tasks
colin-axner opened this issue Jul 5, 2023 · 0 comments
Open
3 tasks

Refactor 02-client keeper to use testing pkg #4013

colin-axner opened this issue Jul 5, 2023 · 0 comments
Labels
testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Testing package i...

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Jul 5, 2023 •
edited
Loading

Summary

Refactor this test to use the testing pkg. It does a lot of manual updates, which are not as robust. While updating to Eden, I noticed that "valid duplicate update" is incorrectly written as it doesn't update the client state as well

Refactor 02-client tests to remove usage of pre testing pkg fields on the keeper test suite in keeper_test.go

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the testing Testing package and unit/integration tests label Jul 5, 2023
@colin-axner colin-axner added the type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. label Jul 5, 2023
@colin-axner colin-axner mentioned this issue Jul 5, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 6, 2023
@colin-axner colin-axner changed the title Refactor TestUpdateClientTendermint in 02-client keeper to use testing pkg Refactor 02-client keeper to use testing pkg Jan 15, 2024
This was referenced Mar 11, 2024
Merged
Merged
This was referenced Mar 25, 2024
Merged
Merged
This was referenced Apr 2, 2024
Merged
Merged
Merged
Merged
This was referenced Apr 11, 2024
Merged
Merged
This was referenced Apr 29, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Status: Backlog 🕐
Milestone
Testing package improvements
Development

No branches or pull requests
1 participant
@colin-axner