Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ValidateBasic tests for Channel Upgrade Types #3464

Closed
3 tasks
chatton opened this issue Apr 17, 2023 · 3 comments
Closed
3 tasks

Add ValidateBasic tests for Channel Upgrade Types #3464

chatton opened this issue Apr 17, 2023 · 3 comments
Labels
04-channel
Milestone
04-channel upgrad...

Comments

@chatton
Copy link
Contributor

chatton commented Apr 17, 2023

Summary

Follow up for #3451

Add validate basic tests for Upgrade and Upgrade Fields

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chatton chatton added this to the 04-channel upgrades alpha milestone Apr 17, 2023
@chatton chatton changed the title Add ValidateBasic tests for Upgrade Types Add ValidateBasic tests for Channel Upgrade Types Apr 17, 2023
@phamminh0811
Copy link
Contributor

phamminh0811 commented May 4, 2023 •
edited
Loading

hi @chatton , can I handle this issue?

@DimitrisJim
Copy link
Contributor

seems this was done with 6d80a36?

@crodriguezvega
Copy link
Contributor

Indeed, thanks for noticing that, @DimitrisJim!

Closed by #3709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
04-channel
Projects
None yet
Milestone
04-channel upgrades alpha
Development

No branches or pull requests
4 participants
@crodriguezvega @chatton @DimitrisJim @phamminh0811