Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Update parameters and chain-id references from cosmoshub-3 to cosmoshub-4 #37

Closed
uditvira opened this issue Jun 23, 2021 · 1 comment · Fixed by #42
Closed

Update parameters and chain-id references from cosmoshub-3 to cosmoshub-4 #37

uditvira opened this issue Jun 23, 2021 · 1 comment · Fixed by #42

Comments

@uditvira
Copy link
Contributor

  • update chain-id references
  • confirm parameter defaults
@uditvira uditvira changed the title Update references to cosmoshub-4 Update parameters and chain-id references from cosmoshub-3 to cosmoshub-4 Jun 24, 2021
@uditvira
Copy link
Contributor Author

I compared the genesis files of cosmoshub-3 chain and cosmoshub-4 chain to update the parameters documentation in this repo. I'm dumping my audit here.

  • There are a few places where the parameter information needs updating, which are explained below.
  • It seems like governable parameters in the baseapp are not documented in this repository. This means that there isn't reference information for this currently live parameter change proposal #50 that was made to update block params (MaxBytes and MaxGas)
  • I need to confirm whether there are new modules added that have governable params, which are not currently present in this documentation. The 8 modules with governable params that are currently documented here are: auth, bank, crisis, distribution, gov, mint, slashing, staking
  • I'm working through a better way of structuring these parameters that's reflective of their change history. It would be nice to first complete issue Retroactively add proposals #17 so we can connect back parameter changes and have a clear historical record of the evolution of parameters.

Comparing module parameters in cosmoshub-3 and cosmoshub-4 genesis files

Auth module

Summary

Auth module params are unchanged at genesis.

Details

cosmoshub-3

{
  "max_memo_characters": "512",
  "sig_verify_cost_ed25519": "590",
  "sig_verify_cost_secp256k1": "1000",
  "tx_sig_limit": "7",
  "tx_size_cost_per_byte": "10"
}

cosmoshub-4

{
  "max_memo_characters": "512",
  "sig_verify_cost_ed25519": "590",
  "sig_verify_cost_secp256k1": "1000",
  "tx_sig_limit": "7",
  "tx_size_cost_per_byte": "10"
}

Bank module

Summary

  • Bank module has changed params structure. It has added a default send enabled value which can be overridden by send_enabled array which can enable sends per denom.
  • Value for Cosmos Hub remains unchanged

Details

cosmoshub-3

{
  "send_enabled": true
}

cosmoshub-4

{
  "default_send_enabled": true,
  "send_enabled": []
}

Crisis module

Summary

Crisis module parameters are unchanged.

Details

cosmoshub-3

{
  "constant_fee": {
    "amount": "1333000000",
    "denom": "uatom"
  }
}

cosmoshub-4

{
  "constant_fee": {
    "amount": "1333000000",
    "denom": "uatom"
  }
}

Distribution module

Summary

Distribution module parameters are now nested inside a "params" object, but default values are unchanged.

Details

cosmoshub-3

"base_proposer_reward": "0.010000000000000000"
"bonus_proposer_reward": "0.040000000000000000"
"community_tax": "0.020000000000000000"
"withdraw_addr_enabled": true

cosmoshub-4

{
  "base_proposer_reward": "0.010000000000000000",
  "bonus_proposer_reward": "0.040000000000000000",
  "community_tax": "0.020000000000000000",
  "withdraw_addr_enabled": true
}

Gov module

Summary

  • Values of gov params are unchanged at genesis
  • Time period units are now in seconds rather than nanoseconds

Details

cosmoshub-3

deposit_params
{
  "max_deposit_period": "1209600000000000",
  "min_deposit": [
    {
      "amount": "512000000",
      "denom": "uatom"
    }
  ]
}
tally_params
{
  "quorum": "0.400000000000000000",
  "threshold": "0.500000000000000000",
  "veto": "0.334000000000000000"
}
voting_params
{
  "voting_period": "1209600000000000"
}

cosmoshub-4

deposit_params
{
  "max_deposit_period": "1209600s",
  "min_deposit": [
    {
      "amount": "512000000",
      "denom": "uatom"
    }
  ]
}
tally_params
{
  "quorum": "0.400000000000000000",
  "threshold": "0.500000000000000000",
  "veto_threshold": "0.334000000000000000"
}
voting_params
{
  "voting_period": "1209600s"
}

Mint module

Summary

Blocks per year have decreased from 4855015 to 4360000 due to proposal 30

Details

cosmoshub-3

{
  "blocks_per_year": "4855015",
  "goal_bonded": "0.670000000000000000",
  "inflation_max": "0.200000000000000000",
  "inflation_min": "0.070000000000000000",
  "inflation_rate_change": "0.130000000000000000",
  "mint_denom": "uatom"
}

cosmoshub-4

{
  "blocks_per_year": "4360000",
  "goal_bonded": "0.670000000000000000",
  "inflation_max": "0.200000000000000000",
  "inflation_min": "0.070000000000000000",
  "inflation_rate_change": "0.130000000000000000",
  "mint_denom": "uatom"
}

Slashing module

Summary

  • max_evidence_age has been deprecated in this pr
  • downtime_jail_duration has changed units, from nanoseconds to seconds

Details

cosmoshub-3

{
  "downtime_jail_duration": "600000000000",
  "max_evidence_age": "1814400000000000",
  "min_signed_per_window": "0.050000000000000000",
  "signed_blocks_window": "10000",
  "slash_fraction_double_sign": "0.050000000000000000",
  "slash_fraction_downtime": "0.000100000000000000"
}

cosmoshub-4

{
  "downtime_jail_duration": "600s",
  "min_signed_per_window": "0.050000000000000000",
  "signed_blocks_window": "10000",
  "slash_fraction_double_sign": "0.050000000000000000",
  "slash_fraction_downtime": "0.000100000000000000"
}

Staking module

Summary

  • historical_entries parameter is added, with default value set to 1000. I can't find any reasoning behind the 1000 value

Details

cosmoshub-3

{
  "bond_denom": "uatom",
  "max_entries": 7,
  "max_validators": 125,
  "unbonding_time": "1814400000000000"
}

cosmoshub-4

{
  "bond_denom": "uatom",
  "historical_entries": 10000,
  "max_entries": 7,
  "max_validators": 125,
  "unbonding_time": "1814400s"
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant